[browser][ws] Fix WebSocket state propagation delay in ReceiveAsync
#99612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilonatommy
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing |
maraf
approved these changes
Mar 13, 2024
|
/backport to release/8.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/8262843184 |
|
@ilonatommy backporting to release/8.0-staging failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Fix + test.
Using index info to reconstruct a base tree...
M src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/BrowserWebSockets/BrowserInterop.cs
M src/libraries/System.Net.WebSockets.Client/tests/CloseTest.cs
A src/mono/browser/runtime/exports-internal.ts
A src/mono/browser/runtime/web-socket.ts
Falling back to patching base and 3-way merge...
Auto-merging src/mono/wasm/runtime/web-socket.ts
CONFLICT (content): Merge conflict in src/mono/wasm/runtime/web-socket.ts
Auto-merging src/mono/wasm/runtime/exports-internal.ts
Auto-merging src/libraries/System.Net.WebSockets.Client/tests/CloseTest.cs
Auto-merging src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/BrowserWebSockets/BrowserInterop.cs
CONFLICT (content): Merge conflict in src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/BrowserWebSockets/BrowserInterop.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix + test.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@ilonatommy an error occurred while backporting to release/8.0-staging, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #99545.
Contributes to #96359
We should not inform managed code about ws
Closedstatus till all the messages from the event buffer that is populated ononMessagedon't get read. This gives the client an opportunity to read all the messages even when the socket is already closed + removes the inconsistency in behavior.