Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PersistedAssemblyBuilder public and update all references #99660

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

buyaa-n
Copy link
Contributor

@buyaa-n buyaa-n commented Mar 13, 2024

  • Make Persisted AssemblyBuilder implementation public
  • Move all related new APIs from AssemblyBuilder to into PersistedAssemblyBuilder
  • Add public MetadataBuilder GenerateMetadata(out BlobBuilder ilStream, out BlobBuilder mappedFieldData); method
  • Add corresponding tests
  • Update references in runtime accordingly

Related to #92975
Fixes #97015

Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@buyaa-n buyaa-n added this to the 9.0.0 milestone Mar 13, 2024
@buyaa-n buyaa-n merged commit 3d7ebcf into dotnet:main Mar 13, 2024
178 checks passed
@buyaa-n buyaa-n deleted the persisted-ab branch March 13, 2024 20:26
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add PersistedAssemblyBuilder type
2 participants