Add option to --produce_repro in superpmi.py script #99723
Conversation
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
@dotnet/jit-contrib |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
src/coreclr/scripts/superpmi.py
Outdated
| if not coreclr_args.produce_repro: | ||
| pass |
There was a problem hiding this comment.
This doesn't do anything. Do you want pass to be return? Or maybe don't do anything here since it won't find any .mc files.
There was a problem hiding this comment.
sure, I think I will just remove this because it won't find any mc files. That's why it worked as expected locally when i was testing.
| @@ -2153,6 +2166,11 @@ def replay_with_asm_diffs(self): | |||
| "-details", detailed_info_file, # Detailed information about each context | |||
| "-r", os.path.join(temp_location, "repro"), # Repro name prefix, create .mc repro files | |||
| ] | |||
| if self.coreclr_args.produce_repro: | |||
| flags += [ | |||
| "-r", os.path.join(temp_location, "repro") # Repro name prefix, create .mc repro files | |||
There was a problem hiding this comment.
You need to remove the -r above, or you'll be adding it twice.
|
@kunalspathak This broke collections: e.g., https://dev.azure.com/dnceng/internal/_build/results?buildId=2406194&view=results |
|
Fixed here: #99867 |
During local development, we now will have to use
--produce_reproif we want superpmi.exe to produce*.mcfiles. This way, we will skip producing the *.mc files in CI.