Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Remove BBF_NONE_QUIRK #99907

Merged
merged 1 commit into from
Mar 18, 2024
Merged

JIT: Remove BBF_NONE_QUIRK #99907

merged 1 commit into from
Mar 18, 2024

Conversation

amanasifkhalid
Copy link
Member

Closes #95998. We no longer check for BBF_NONE_QUIRK anywhere, so this should be a no-diff change.

cc @dotnet/jit-contrib

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 18, 2024
@amanasifkhalid
Copy link
Member Author

asmdiffs are broken for now (comment); since we don't have the latest mainline JIT built, the baseline JIT is out-of-date, so we're seeing diffs from #99783. Locally, this is a no-diff change, with TP wins of ~0.1%.

@amanasifkhalid amanasifkhalid merged commit 5fda474 into dotnet:main Mar 18, 2024
104 of 110 checks passed
@amanasifkhalid amanasifkhalid deleted the remove-bbf-none-quirk branch March 18, 2024 18:21
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees

@amanasifkhalid amanasifkhalid

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[JIT] Remove BBF_NONE_QUIRK
2 participants
@amanasifkhalid @jakobbotsch