-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add publish support on ARM platform #1387
Conversation
19d2e65
to
c9271d4
Compare
@@ -62,13 +62,13 @@ | |||
Text="Cross-OS native compilation is not supported. https://github.com/dotnet/corert/issues/5458" /> | |||
|
|||
<Error Condition="'$(DisableUnsupportedError)' != 'true' and !($(RuntimeIdentifier.EndsWith('x64')) or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have DisableUnsupportedError
to allow suppressing the error message. Adding the new platform to the list here is one of the last steps once everything is working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General question. Does DisableUnsupportedError
is dotnet/runtime
property, or purely NativeAOT construct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is NativeAOT specific.
I would like to ask again. Does something blocking ARM right now? What other quality issues left? |
Are all smoke tests |
After #1511 I see following error
The error means that I only build following subsets - |
This is non-fatal error. Linux x64 runs have it too
Do the same steps work fine on native Linux x64? My guess is that you may be missing "The Debug/Release flag should match the flag that was passed to build.cmd in the previous step." or something like that from https://github.com/dotnet/runtimelab/blob/feature/NativeAOT/docs/workflow/building/coreclr/nativeaot.md#running-tests |
This work should continue in dotnet/runtime repo |
Allow publish process on ARM