Convert Scratch lookup to binary search #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshung
approved these changes
Jul 28, 2022
amanasifkhalid
force-pushed
the
binary-search
branch
from
3c46175
to
3c5c6a6
Compare
|
@cshung I pushed changes addressing your feedback. For asserting the lookup table's size is <= the runtime function table's size, I changed the method's parameter list to just pass |
cshung
reviewed
Jul 28, 2022
amanasifkhalid
force-pushed
the
binary-search
branch
from
3c5c6a6
to
cebc025
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary work for #1903: Before making any design changes, we should try using binary search over the Scratch table, and profile the performance gain. I likely won't have time to fully pursue this task, but we can at least get rid of the linear search for now.