[NativeAOT-LLVM] Build target and host packages for WASM on the same platform #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches how the build for other artifacts is set up. We must take care to disable building the corresponding "host" platform, otherwise the publishing process will be racy (since both builds will end up producing "host" packages of the same name).
SingleAccretion
changed the title
|
Packages produced in the test run looked reasonable. |
This reverts commit db3c8e4.
SingleAccretion
commented
Dec 18, 2022
Comment on lines
42
to
43
| - ${{ else }}: | ||
| - script: $(Build.SourcesDirectory)/src/tests/build$(scriptExt) nativeaot $(buildConfigUpper) ${{ parameters.archType }} ${{ parameters.testFilter }} |
There was a problem hiding this comment.
Miscellaneous YAML cleanup.
|
@dotnet/nativeaot-llvm |
|
This looks good to me. |
The `''` in `'tree nativeaot'` are significant.
|
Part of the change unintentionally made the CI run all of the Pri0 runtime tests. I have reverted that. |
|
Was the loss of the WIndows x64 Release build an intentional effect of this PR? |
|
Yes, it was. What used to be built "on" the windows_x64 platform is now built "on" browser_wasm_win. Otherwise we would be in a situation where the win-x64 package would be produced twice (and only one of them would have the right content). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches how the build for other artifacts is set up.
We must take care to disable building the corresponding "host" platform, otherwise the publishing process will be racy (since both builds will end up producing "host" packages of the same name).
Hopefully, this is the last fix needed for package publishing to work.