Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NativeAOT-LLVM] Fix the Math.Round intrinsic #2503

Merged
merged 1 commit into from
Feb 2, 2024
Merged

[NativeAOT-LLVM] Fix the Math.Round intrinsic #2503

merged 1 commit into from
Feb 2, 2024

Conversation

SingleAccretion
Copy link

We want @llvm.roundeven, not @llvm.round.

Found by the time span division test: #2307 (comment).

@SingleAccretion
Fix the Math.Round intrinsic
35aeb74 
We want `@llvm.roundeven`, not `@llvm.round`.
@jkotas jkotas added the area-NativeAOT-LLVM LLVM generation for Native AOT compilation (including Web Assembly) label Feb 2, 2024
yowl
yowl approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@yowl yowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit 65b28a6 into dotnet:feature/NativeAOT-LLVM Feb 2, 2024
11 checks passed
@filipnavara filipnavara mentioned this pull request Feb 3, 2024
Closed
@SingleAccretion SingleAccretion deleted the Fix-Time-Span-Division-Up branch February 3, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yowl yowl yowl approved these changes

Assignees
No one assigned
Labels
area-NativeAOT-LLVM LLVM generation for Native AOT compilation (including Web Assembly)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SingleAccretion @yowl @jkotas