[NativeAOT-LLVM] Fix a GC hole in the new LSSA implementation #2531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to be careful about not depending on stale shadow stack state when making decision not to spill a def derived from an already spilled value. This has some cost, but an overly large one, about 0.15% in terms of code size for HelloWasm.
Without the fix, this test quickly crashed under stress. With the fix, it passes without issue.
SingleAccretion
force-pushed
the
LSSA-Gc-Hole
branch
from
cc03060 to
644d8e6
Compare
|
@dotnet/nativeaot-llvm |
yowl
approved these changes
Mar 23, 2024
|
Thank you! |
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be careful about not depending on stale shadow stack state when making decisions not to spill a def derived from an already spilled value.
This has some cost, but an overly large one, about 0.15% in terms of code size for HelloWasm.
Ref: #2514 (comment).