Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NativeAOT-LLVM] Address post-merge tasks #2542

Merged
merged 2 commits into from
Apr 14, 2024
Merged

[NativeAOT-LLVM] Address post-merge tasks #2542

merged 2 commits into from
Apr 14, 2024

Conversation

SingleAccretion
Copy link

@SingleAccretion SingleAccretion commented Apr 5, 2024 •
edited
Loading

  1. Switch to using WasmEnableThreads in the few places that matter.
  2. Add some tests for the small atomics.

Ref: #2472.

@jkotas jkotas added the area-NativeAOT-LLVM LLVM generation for Native AOT compilation (including Web Assembly) label Apr 5, 2024
@SingleAccretion SingleAccretion marked this pull request as ready for review April 5, 2024 21:26
@SingleAccretion
Copy link
Author

@dotnet/nativeaot-llvm

yowl
yowl approved these changes Apr 14, 2024
View reviewed changes
Copy link
Contributor

@yowl yowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jkotas jkotas merged commit 86c9df1 into dotnet:feature/NativeAOT-LLVM Apr 14, 2024
11 checks passed
@SingleAccretion SingleAccretion deleted the ThreadingProperties branch April 20, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yowl yowl yowl approved these changes

Assignees
No one assigned
Labels
area-NativeAOT-LLVM LLVM generation for Native AOT compilation (including Web Assembly)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SingleAccretion @yowl @jkotas