[Swift bindings] Add bindings experimental NuGet to the dotnet-experimental feed #2878
+171
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotlarmilos
requested review from
dalexsoto,
rolfbjarne,
stephen-hawley,
jkurdek and
Copilot
4 tasks
jkotas
reviewed
Dec 13, 2024
| </ItemGroup> | ||
|
|
||
| <!-- Reference Swift.Bindings.MacOSX.Experimental from dotnet-experimental feed --> |
There was a problem hiding this comment.
For tests, I think you want to reference local copy of the package that was just built.
3 tasks
Base automatically changed from
swift-bindings/testing-framework
to
feature/swift-bindings
December 17, 2024 15:53
… into swift-bindings/experimental-bindings
|
@EgorBot -codesafety |
… into swift-bindings/experimental-bindings
akoeplinger
approved these changes
Dec 18, 2024
| echo "Generating ABI for framework '$framework', platform '$platform', architecture '$arch'" | ||
|
|
||
| local sdk_path=$(xcrun -sdk $(echo "$platform" | tr '[:upper:]' '[:lower:]') --show-sdk-path) | ||
| local swift_interface_path="/Applications/Xcode.app/Contents/Developer/Platforms/${platform}.platform/Developer/SDKs/${platform}.sdk/System/Library/Frameworks/${framework}.framework/Versions/Current/Modules/${framework}.swiftmodule/${arch}.swiftinterface" |
There was a problem hiding this comment.
nit: use xcode-select -p to figure out path to Xcode rather than hardcoding /Applications
| function InvokeProjectionTooling { | ||
| local framework=$1 | ||
|
|
||
| $scriptroot/.dotnet/dotnet $scriptroot/artifacts/bin/Swift.Bindings/Release/net9.0/Swift.Bindings.dll -a "$framework" -o "./" |
There was a problem hiding this comment.
Suggested change
| $scriptroot/.dotnet/dotnet $scriptroot/artifacts/bin/Swift.Bindings/Release/net9.0/Swift.Bindings.dll -a "$framework" -o "./" | |
| $scriptroot/dotnet.sh $scriptroot/artifacts/bin/Swift.Bindings/Release/net9.0/Swift.Bindings.dll -a "$framework" -o "./" |
| </Project> | ||
| EOL | ||
|
|
||
| $scriptroot/.dotnet/dotnet pack "$project_file" |
There was a problem hiding this comment.
Suggested change
| $scriptroot/.dotnet/dotnet pack "$project_file" | |
| $scriptroot/dotnet.sh pack "$project_file" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds binding generation step to the distribution pipeline. To enable testing of the StoreKit framework, we want to provide an experimental NuGet that can be used in real-world applications such as HikingApp. This approach will also allow us to track binding coverage and identify areas for improvement.
Changes
This change introduces a script for generating bindings that runs after the build in the distribution pipeline. The script extracts the ABI for selected frameworks, runs the tooling, and generates NuGet package from source code. The package is then distributed using
darcin thedotnet-experimentalfeed.Verification
The pipeline was invoked manually. The NuGet package will become available once this change is merged into the
feature/swift-bindingsbranch, which is configured for feed publishing.Follow-up
Once the package becomes available, we will start introducing framework tests as MacCatalyst apps and track coverage of supported Swift language features from included frameworks.