[Swift bindings] Upgrade dotnet runtime version to 9.0.0 #2879
Conversation
…101.1 (#2747) Microsoft.DotNet.Arcade.Sdk From Version 10.0.0-beta.24515.3 -> To Version 10.0.0-beta.24551.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…110.1 (#2763) Microsoft.DotNet.Arcade.Sdk From Version 10.0.0-beta.24551.1 -> To Version 10.0.0-beta.24560.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…114.1 (#2784) Microsoft.DotNet.Arcade.Sdk From Version 10.0.0-beta.24560.1 -> To Version 10.0.0-beta.24564.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…122.3 (#2808) Microsoft.DotNet.Arcade.Sdk From Version 10.0.0-beta.24564.1 -> To Version 10.0.0-beta.24572.3 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…128.2 (#2819) Microsoft.DotNet.Arcade.Sdk From Version 10.0.0-beta.24572.3 -> To Version 10.0.0-beta.24578.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…206.6 (#2865) Microsoft.DotNet.Arcade.Sdk From Version 10.0.0-beta.24578.2 -> To Version 10.0.0-beta.24606.6 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…to swift-bindings/upgrade-dotnet-9.0.0
| # Skip brew update for now, see https://github.com/actions/setup-python/issues/577 | ||
| # brew update --preinstall | ||
| brew bundle --no-upgrade --no-lock --file=- <<EOF | ||
| brew "cmake" |
There was a problem hiding this comment.
You might want to talk to @mandel-macaque about this. I don't know the current state of things, but my understanding is that there are some issues around using brew
There was a problem hiding this comment.
This is an arcade change and I don't think our CI relies on it.
|
Why did this bump the .NET SDK version to .NET 10? was this necessary? |
|
It is not necessary, but it is nice to have. Transitioning between different .NET versions in BTfS was a non-trivial task. Now, we can avoid this by performing periodic upgrades. The arcade changes are not automated on this branch, so we manually sync it with our base branch (standalone-template). |
|
I understand that this is nice to have, however I'm not sure whether it is worth it. For example bumping SDK version to .NET 10 broke my vscode dev kit, making local development a bit of a pain. Have you tested this scenario before the the bump? |
|
I haven't tested it with vscode devkit. Is that a known issue in .NET 10? Our CI pipeline includes tests, but it does not include the devkit. |
|
This was a vscode issue similar to microsoft/vscode-dotnettools#808. Going forward, we will test such changes on multiple contributors' machines before merging them. |
Description
This PR upgrades the runtime to version 9.0.0, along with additional changes from arcade.
The
./build.shscript installs the new version of dotnet locally in the.dotnetdirectory. When runningdotnet test, it doesn't automatically detect the local version. To resolve this, add the directory to the path:export PATH="./.dotnet:$PATH".