Implement support for configurable generator options. #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elab into msbuild-options
…reSourceGeneratorCompilation.
jkoritzinsky
added
the
area-DllImportGenerator
50 tasks
DllImportGenerator/DllImportGenerator/Microsoft.Interop.DllImportGenerator.props
Show resolved
Hide resolved
DllImportGenerator/DllImportGenerator/Marshalling/MarshallingGenerator.cs
Show resolved
Hide resolved
DllImportGenerator/DllImportGenerator.UnitTests/DllImportGeneratorOptionsProvider.cs
Show resolved
Hide resolved
DllImportGenerator/DllImportGenerator.UnitTests/DllImportGeneratorOptionsProvider.cs
Outdated
Show resolved
Hide resolved
DllImportGenerator/DllImportGenerator.UnitTests/DllImportGeneratorOptionsProvider.cs
Show resolved
Hide resolved
…er than the forwarding call.
Signed-off-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
AaronRobinsonMSFT
approved these changes
Jan 4, 2021
| { | ||
| public static class OptionsHelper | ||
| { | ||
| public const string UseMarshalTypeOption = "build_property.DllImportGenerator_UseMarshalType"; |
There was a problem hiding this comment.
If this can be private please mark them as such.
There was a problem hiding this comment.
These are public so the tests can access them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement support for a "forwarder" mode and implement an option to emit references to the Marshal type when the MarshalEx type is requested to support perf testing and integration with dotnet/runtime respectively.
Uses https://github.com/dotnet/roslyn/blob/master/docs/features/source-generators.cookbook.md#consume-msbuild-properties-and-metadata as the basis for the feature.
The
DllImportGenerator_UseMarshalTypeMSBuild property changes usages of theMarshalExtype to be theMarshaltype.The
DllImportGenerator_GenerateForwardersMSBuild property causes the generator to emit functions that forward to built-in P/Invoke stubs instead of handling the marshalling in the generated code.