Skip to content

port change done in inner snippet #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2018
Merged

port change done in inner snippet #196

merged 1 commit into from
Jul 20, 2018

Conversation

@mairaw
Copy link
Contributor

@mairaw mairaw commented Jul 19, 2018

Port change from dotnet/docs#6077

@mairaw mairaw requested a review from BillWagner as a code owner July 19, 2018 20:17
JRAlexander
JRAlexander approved these changes Jul 19, 2018
View reviewed changes
Copy link
Contributor

@JRAlexander JRAlexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @mairaw!

@JRAlexander JRAlexander added the verify-build-before-merge Indicates PRs that are waiting for the build to finish before they get merged label Jul 19, 2018
BillWagner
BillWagner approved these changes Jul 20, 2018
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. You can :shipit: when ready.

@mairaw mairaw merged commit 37108bf into master Jul 20, 2018
@mairaw mairaw deleted the mairaw-patch-1 branch July 20, 2018 16:04
karelz pushed a commit to karelz/samples that referenced this pull request Aug 31, 2018
@mairaw @karelz
port change done in inner snippet (dotnet#196)
ab942ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner BillWagner approved these changes

+1 more reviewer

@JRAlexander JRAlexander JRAlexander approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

verify-build-before-merge Indicates PRs that are waiting for the build to finish before they get merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mairaw @BillWagner @JRAlexander