Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datetime.parse and string.format C# samples #3598

Merged
merged 3 commits into from
May 21, 2020

Conversation

gewarren
Copy link
Contributor

These samples were accidentally deleted in #2064.

@BillWagner
Copy link
Member

I agree that we should restore these. But, should they now be in the dotnet-api-docs repo instead?

@gewarren
Copy link
Contributor Author

I agree that we should restore these. But, should they now be in the dotnet-api-docs repo instead?

I'll do whatever is recommended by you and @Thraka. These snippets already exist in the API docs repo, but in a slightly different format. For example, this snippet in the API docs repo is encompassed in this file that's part of the sample project. So in the API repo, they exist as standalone files without a project file. In this format that I need to resurrect somewhere, the snippet tags aren't included and various snippets are combined into a runnable program with command line UI.

@gewarren
Copy link
Contributor Author

@Thraka Do you think I should move this into the API repo instead, even though there will be some duplication in the code?

@Thraka
Copy link
Contributor

Thraka commented May 20, 2020

This looks complete, it's designed as a sample and not as a snippet. I think we should restore it and convert it to a true sample.

@gewarren gewarren marked this pull request as draft May 20, 2020 21:24
@gewarren gewarren marked this pull request as ready for review May 20, 2020 21:50
@gewarren
Copy link
Contributor Author

@BillWagner or @Thraka Does this look good? Can you approve if so?

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

@gewarren gewarren merged commit 503e70c into dotnet:master May 21, 2020
@gewarren gewarren deleted the api-snippets branch May 21, 2020 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants