Create MSIX package for WinForms Core app #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsplaisted
reviewed
Oct 17, 2018
|
|
||
| To use the Windows Packaging Project (wapproj) you need to install the Universal Windows workload in Visual Studio. | ||
|
|
||
| To produce `MSIX` packages you must have the **Windows 10 Octobe 2018 SDK** (aka 10.0.17763), otherwise the generated package will have the `APPX` extension. |
|
|
||
| To produce `MSIX` packages you must have the **Windows 10 Octobe 2018 SDK** (aka 10.0.17763), otherwise the generated package will have the `APPX` extension. | ||
|
|
||
| To install MSIX packages you need the **Windows 10 Octobe 2018 Update**. |
Add debugger type
rpetrusha
changed the title
rpetrusha
changed the title
rpetrusha
suggested changes
Oct 19, 2018
| @@ -0,0 +1,51 @@ | |||
| # MSIX Windows Forms Core Application | |||
|
|
|||
| This sample shows how to use the Windows Packaging Project to package a WinForms application running on Core. | |||
|
|
||
| To use the Windows Packaging Project (wapproj) you need to install the Universal Windows workload in Visual Studio. | ||
|
|
||
| To produce `MSIX` packages you must have the **Windows 10 October 2018 SDK** (aka 10.0.17763), otherwise the generated package will have the `APPX` extension. |
There was a problem hiding this comment.
- comma after "packages"
- semicolon before "otherwise", and a comma after "otherwise"
|
|
||
| To produce `MSIX` packages you must have the **Windows 10 October 2018 SDK** (aka 10.0.17763), otherwise the generated package will have the `APPX` extension. | ||
|
|
||
| To install MSIX packages you need the **Windows 10 October 2018 Update** |
There was a problem hiding this comment.
nit: extra space bewtween "need" and "the". But this sentence can be deleted, since it duplicates line 9.
|
|
||
| ## Customize the Packaging Project | ||
|
|
||
| Currently, the packaging project does not support .NET Core applications, as a workaround we updated the project files to call the `publish` target to produce a self-contained app, and fix the manifest entry point. |
There was a problem hiding this comment.
- period after ".NET Core applications"
- as a workaround we --> As a workaround, we
- and fix --> and to fix
|
|
||
| Currently, the packaging project does not support .NET Core applications, as a workaround we updated the project files to call the `publish` target to produce a self-contained app, and fix the manifest entry point. | ||
|
|
||
| In the .NET core csproj add: |
There was a problem hiding this comment.
.NET core csproj --> .NET Core .csproj file
| </Target> | ||
| ``` | ||
|
|
||
| In the wapproj modify the project `ProjectReference` element: |
There was a problem hiding this comment.
- wapproj --> .wapproj file,
- "project" can be deleted
Addressing @rpetrusha feedback
rpetrusha
approved these changes
Oct 22, 2018
|
This looks good, @rido-min. Is it ready to merge, or should anyone else review it? |
|
@rido-min Looks good to me. |
|
Can we merge this one now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This sample uses the Windows Packaging project to produce an MSIX from a .NET Core self contained application.