Remove condition unnecessary #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lucasnobredev I added the WIP label to this PR. Rather than remove this code, I'd like us to come up with a better sample that shows the value of discards in pattern matching scenarios. I don't have really good ones top of mind, but I'll chat a bit with @rpetrusha and others to make some suggestions. |
BillWagner
approved these changes
Nov 14, 2018
There was a problem hiding this comment.
This LGTM @lucasnobredev
I'll 
this PR now.
Thanks for working with @rpetrusha and I to resolve how we explain these concepts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is from dotnet/docs#8727.
Fixes dotnet/docs#8727