Skip to content

Fix strings with s uppercase #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 15, 2018
Merged

Fix strings with s uppercase #426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
565fdf1
remove of condition unecessary
lucasnobredev Oct 30, 2018
773fbf0
fix strings with s uppercase
lucasnobredev Oct 30, 2018
7541b11
put again condition with discard
lucasnobredev Oct 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions snippets/csharp/VS_Snippets_CLR_System/system.object.tostring/cs/customize1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ public CList(IEnumerable<T> collection) : base(collection)
public CList() : base()
{}

public override String ToString()
public override string ToString()
{
String retVal = String.Empty;
string retVal = string.Empty;
foreach (T item in this) {
if (String.IsNullOrEmpty(retVal))
if (string.IsNullOrEmpty(retVal))
retVal += item.ToString();
else
retVal += String.Format(", {0}", item);
retVal += string.Format(", {0}", item);
}
return retVal;
}
Expand Down
18 changes: 9 additions & 9 deletions snippets/csharp/VS_Snippets_CLR_System/system.object.tostring/cs/customize2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,29 +4,29 @@

public static class StringExtensions
{
public static String ToString2<T>(this List<T> l)
public static string ToString2<T>(this List<T> l)
{
String retVal = String.Empty;
string retVal = string.Empty;
foreach (T item in l)
retVal += String.Format("{0}{1}", String.IsNullOrEmpty(retVal) ?
retVal += string.Format("{0}{1}", string.IsNullOrEmpty(retVal) ?
"" : ", ",
item);
return String.IsNullOrEmpty(retVal) ? "{}" : "{ " + retVal + " }";
return string.IsNullOrEmpty(retVal) ? "{}" : "{ " + retVal + " }";
}

public static String ToString<T>(this List<T> l, String fmt)
public static string ToString<T>(this List<T> l, string fmt)
{
String retVal = String.Empty;
string retVal = string.Empty;
foreach (T item in l) {
IFormattable ifmt = item as IFormattable;
if (ifmt != null)
retVal += String.Format("{0}{1}",
String.IsNullOrEmpty(retVal) ?
retVal += string.Format("{0}{1}",
string.IsNullOrEmpty(retVal) ?
"" : ", ", ifmt.ToString(fmt, null));
else
retVal += ToString2(l);
}
return String.IsNullOrEmpty(retVal) ? "{}" : "{ " + retVal + " }";
return string.IsNullOrEmpty(retVal) ? "{}" : "{ " + retVal + " }";
}
}

Expand Down
28 changes: 14 additions & 14 deletions snippets/csharp/VS_Snippets_CLR_System/system.object.tostring/cs/tostringoverload1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@
public class Automobile
{
private int _doors;
private String _cylinders;
private string _cylinders;
private int _year;
private String _model;
private string _model;

public Automobile(String model, int year , int doors,
String cylinders)
public Automobile(string model, int year , int doors,
string cylinders)
{
_model = model;
_year = year;
Expand All @@ -20,40 +20,40 @@ public Automobile(String model, int year , int doors,
public int Doors
{ get { return _doors; } }

public String Model
public string Model
{ get { return _model; } }

public int Year
{ get { return _year; } }

public String Cylinders
public string Cylinders
{ get { return _cylinders; } }

public override String ToString()
public override string ToString()
{
return ToString("G");
}

public String ToString(String fmt)
public string ToString(string fmt)
{
if (String.IsNullOrEmpty(fmt))
if (string.IsNullOrEmpty(fmt))
fmt = "G";

switch (fmt.ToUpperInvariant())
{
case "G":
return String.Format("{0} {1}", _year, _model);
return string.Format("{0} {1}", _year, _model);
case "D":
return String.Format("{0} {1}, {2} dr.",
return string.Format("{0} {1}, {2} dr.",
_year, _model, _doors);
case "C":
return String.Format("{0} {1}, {2}",
return string.Format("{0} {1}, {2}",
_year, _model, _cylinders);
case "A":
return String.Format("{0} {1}, {2} dr. {3}",
return string.Format("{0} {1}, {2} dr. {3}",
_year, _model, _doors, _cylinders);
default:
String msg = String.Format("'{0}' is an invalid format string",
string msg = string.Format("'{0}' is an invalid format string",
fmt);
throw new ArgumentException(msg);
}
Expand Down
2 changes: 1 addition & 1 deletion snippets/csharp/VS_Snippets_CLR_System/system.object.tostring/cs/tostringoverload2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ public class Example
{
public static void Main()
{
String[] cultureNames = { "en-US", "en-GB", "fr-FR",
string[] cultureNames = { "en-US", "en-GB", "fr-FR",
"hr-HR", "ja-JP" };
Decimal value = 1603.49m;
foreach (var cultureName in cultureNames) {
Expand Down