WinForms DataGridView sample #456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e in the repository root
mjrousos
commented
Nov 12, 2018
windowsforms/datagridview/CSWinFormDataGridView/CustomDataGridViewColumn/MainForm.cs
Outdated
Show resolved
Hide resolved
mjrousos
commented
Nov 12, 2018
|
|
||
| /// <summary> | ||
| /// Returns an image deserialized from a string resource to work around https://github.com/dotnet/corefx/issues/26745 | ||
| /// </summary> |
There was a problem hiding this comment.
Now that there's a fix for dotnet/corefx#26745 in the works, I can probably remove this.
…s the repo's MIT license
rpetrusha
suggested changes
Nov 12, 2018
windowsforms/datagridview/CSWinFormDataGridView/JustInTimeDataLoading/ReadMe.txt
Outdated
Show resolved
Hide resolved
windowsforms/datagridview/CSWinFormDataGridView/MultipleLayeredColumnHeader/ReadMe.txt
Outdated
Show resolved
Hide resolved
windowsforms/datagridview/CSWinFormDataGridView/EditingControlHosting/ReadMe.txt
Outdated
Show resolved
Hide resolved
|
@rpetrusha, I've updated the PR based on your comments. Any other suggestions here or is this one ready to merge? |
rpetrusha
approved these changes
Nov 19, 2018
|
Thanks for updating your PR, @mjrousos. This is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET Core 3 WinForms sample demonstrating a variety of DataGridView scenarios. Ported from https://code.msdn.microsoft.com/windowsdesktop/CSWinFormDataGridView-29783221