Skip to content

Conversation

@mairaw
Copy link
Contributor

@mairaw mairaw commented Nov 12, 2018

Also changed the VB version to match the C# and C++ ones.

Fixes dotnet/docs#8994

@hDoubleE
Copy link
Contributor

I'm a total newbie and this is my very first attempt at contributing to open source. I read ms Docs all the time and kinda just tried this out to see what would happen. AMAZING! Thanks so much for accepting my feedback. You're team rocks!

Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can merge when you're ready, @mairaw.

@mairaw
Copy link
Contributor Author

mairaw commented Nov 13, 2018

You're welcome @hDoubleE and thank you so much for the kind words! You can find more info on how to contribute at https://docs.microsoft.com/en-us/contribute/. We usually encourage folks to submit PRs as well, I just thought this one was a bit more complicated since it involved more than one file.

@mairaw mairaw merged commit 9a22550 into dotnet:master Nov 13, 2018
@mairaw mairaw deleted the linkedlist branch November 13, 2018 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants