Added snippets for true and false operators/literals #493
Conversation
There was a problem hiding this comment.
Thanks for putting this together @pkulikov
I requested changed, because I Think there's a possible issue in the logic. I could be wrong, but I want to make sure we discuss this and come to agreement before we 
.
Take a look at the comments, and let me know your thoughts.
| return Red; | ||
| } | ||
|
|
||
| return Green; |
There was a problem hiding this comment.
I think there's an issue here. For x & y & z work correctly when z is Yellow, this should return Yellow when one of x or y is Yellow.
Do you agree?
There was a problem hiding this comment.
For
x & y & zwork correctly...
to clarify: by "correctly" you mean that the & overload must be associative, so (x & y) & z == x & (y & z)
Yes, I agree then. Will make an update soon.
There was a problem hiding this comment.
@BillWagner I've addressed your feedback; thanks for review.
I've checked the updated definition for all possible x, y, and z values: now the & operator is commutative and associative. In particular, that means that x1 & ... & xN is Yellow iff there is only one operand which is Yellow with all others being Green. That's why I've updated the true definition to return true value for Yellow operand. The following requirement is met:
if only one sub-system is yellow, we can launch.
|
Thanks for making these updates. I'll |
2 participants
Supports dotnet/docs#9356