Skip to content

update TFMs and package versions for .NET Core 2.2 release #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2018
Merged

update TFMs and package versions for .NET Core 2.2 release #494

merged 1 commit into from
Dec 4, 2018

Conversation

@mairaw
Copy link
Contributor

@mairaw mairaw commented Dec 3, 2018

Contributes to dotnet/docs#9357

What I did:

  • Changed the TFM to netcoreapp2.2 (except for a few samples involving nunit where template is still using 2.1 - see https://github.com/dotnet/cli/issues/10425)
  • Reviewed package versions
  • Removed core/libraries folder. Didn't seem to be used.
  • for the csharp/linq samples cleaned up a bunch of stuff from migration and just left the usual tags

@mairaw mairaw self-assigned this Dec 3, 2018
BillWagner
BillWagner approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @mairaw

You can :shipit: when ready.

@mairaw mairaw merged commit b6b4adb into dotnet:master Dec 4, 2018
@mairaw mairaw deleted the 2.2 branch December 4, 2018 17:56
@Youssef1313 Youssef1313 mentioned this pull request Nov 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner BillWagner approved these changes

@rpetrusha rpetrusha Awaiting requested review from rpetrusha

Assignees

@mairaw mairaw

Labels

None yet

Projects

None yet

Milestone

Sprint 145 (11/26/2018 - 12/14/2018)

Development

Successfully merging this pull request may close these issues.

2 participants

@mairaw @BillWagner