Skip to content

Rename parameter to make the steps more consistent #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2018
Merged

Rename parameter to make the steps more consistent #502

merged 1 commit into from
Dec 5, 2018

Conversation

@mikkelbu
Copy link
Contributor

@mikkelbu mikkelbu commented Dec 5, 2018

rpetrusha
rpetrusha approved these changes Dec 5, 2018
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mikkelbu, for renaming the key parameter and using nameof. I'll merge your PR now.

@rpetrusha rpetrusha merged commit 4a60fd6 into dotnet:master Dec 5, 2018
@mikkelbu mikkelbu deleted the rename-parameter branch December 5, 2018 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner Awaiting requested review from BillWagner

1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mikkelbu @rpetrusha