Skip to content

Conversation

@lindexi
Copy link
Member

@lindexi lindexi commented Dec 18, 2018

Summary

In corefx/coding-style.md at master · dotnet/corefx NO.1, NO3, NO.11

  • We use Allman style braces, where each brace begins on a new line. A single line statement block can go without braces but the block must be properly indented on its own line and must not be nested in other statement blocks that use braces.

  • We use _camelCase for internal and private fields

  • We use language keywords instead of BCL types

In [corefx/coding-style.md at master · dotnet/corefx](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md ) NO.1, we use Allman style braces, where each brace begins on a new line. A single line statement block can go without braces but the block must be properly indented on its own line and must not be nested in other statement blocks that use braces.
In [corefx/coding-style.md at master · dotnet/corefx](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md ) NO.3, we use _camelCase for internal and private fields
In [corefx/coding-style.md at master · dotnet/corefx](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md ) NO.11, we use language keywords instead of BCL types.
@lindexi lindexi requested a review from BillWagner as a code owner December 18, 2018 06:34
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this sample @lindexi

I'll approve these changes now.

@BillWagner BillWagner merged commit 0c3b13c into dotnet:master Dec 18, 2018
@mairaw mairaw mentioned this pull request Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants