Skip to content

Conversation

@davidbroetje
Copy link
Contributor

@davidbroetje davidbroetje commented Dec 30, 2018

Summary

In the example the title-cased word "File" is compared with an equivalent word, its lowercase equivalent, its uppercase equivalent, and the word "fıle" (LATIN SMALL LETTER DOTLESS I (U+0131) instead of LATIN SMALL LETTER I (U+0069). The comparison of "File" and "fıle" will already fail because of the case of the letter "F".

Hereby the lowercase "f" in the word "fıle" is changed to uppercase "F".

Fixes dotnet/dotnet-api-docs#1291

@dnfclas
Copy link

dnfclas commented Dec 30, 2018

CLA assistant check
All CLA requirements met.

@davidbroetje davidbroetje changed the title Fix example word (#1291) Fix example word (dotnet/dotnet-api-docs#1291) Dec 30, 2018
@davidbroetje davidbroetje changed the title Fix example word (dotnet/dotnet-api-docs#1291) Fix example word Dec 30, 2018
@rpetrusha rpetrusha added the ✨ 1st-time samples contributor! Indicates PRs from new contributors to the samples repository label Jan 4, 2019
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @davidbroetje, for contributing to the dotnet/samples repo and for addressing dotnet/dotnet-api-docs#1291. We'll merge your PR now.

@rpetrusha rpetrusha merged commit 6d7ab3a into dotnet:master Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ 1st-time samples contributor! Indicates PRs from new contributors to the samples repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants