Skip to content

replace paths with mydocs variable for how-to-enumerate-directories-and-files #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 7, 2019
Merged

replace paths with mydocs variable for how-to-enumerate-directories-and-files #547

merged 4 commits into from
Jan 7, 2019

Conversation

@v-thepet
Copy link
Contributor

@v-thepet v-thepet commented Jan 2, 2019

Summary

Describe your changes here.
Making paths platform agnostic (so they will work on Linux)

Part of dotnet/docs https://mseng.visualstudio.com/TechnicalContent/_workitems/edit/1374049/?triage=true (.NET: Verify content freshness for System.IO task topics)

@v-thepet v-thepet requested a review from BillWagner as a code owner January 2, 2019 19:38
rpetrusha
rpetrusha suggested changes Jan 4, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @v-thepet, for making these examples more platform-independent. I've added a number of suggested changes and comments for you to consider.

Ron Petrusha and others added 3 commits January 4, 2019 15:27
@v-thepet
Copy link
Contributor Author

v-thepet commented Jan 5, 2019

@rpetrusha - Thanks, I have made the changes.

@mairaw mairaw added the changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review label Jan 5, 2019
@rpetrusha
Copy link

Thanks, @v-thepet, for making the additional changes. I'll merge your PR now.

@rpetrusha rpetrusha merged commit 525fbb7 into dotnet:master Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner Awaiting requested review from BillWagner

1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@v-thepet @rpetrusha @mairaw