Corrected XmlDocument variable name #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mairaw
approved these changes
Jan 15, 2019
Contributor
mairaw
left a comment
mairaw
left a comment
There was a problem hiding this comment.
LGTM but left a few comments for you to consider @rpetrusha. Comments would apply to both C# and VB versions.
snippets/csharp/VS_Snippets_CLR/HowToVerifyXMLDocumentRSA/cs/sample.cs
Outdated
Show resolved
Hide resolved
| // Verify the signature of an XML file against an asymmetric | ||
| // algorithm and return the result. | ||
| public static Boolean VerifyXml(XmlDocument Doc, RSA Key) | ||
| public static Boolean VerifyXml(XmlDocument xmlDoc, RSA Key) |
Contributor
There was a problem hiding this comment.
the only weird thing here is that now one param uses camelCase and the other Pascal
Author
There was a problem hiding this comment.
I've changed the casing of Key in both source code files as well. Thanks for noticing Doc here.
…ample.cs Co-Authored-By: rpetrusha <ronpet@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected XmlDocument variable name
Fixes dotnet/docs#9762