Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Orleans ChatRoom sample to match documentation #6988

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

reagcz
Copy link
Contributor

@reagcz reagcz commented Sep 16, 2024

Summary

Change the ChatRoom client sample to use the streamId returned by the IChannelGrain.Join and Leave methods

The README.md for the ChatRoom sample states that

Clients connect to the ChannelGrain for a channel and then subscribe to the stream identified by the Guid returned from the IChannelGrain.Join call

The sample currently creates the streamId manually, instead of using the one returned by the Join and Leave methods.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, and I'll :shipit: now.

@BillWagner BillWagner merged commit 7322f3c into dotnet:main Oct 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants