Skip to content

Conversation

@JRAlexander
Copy link
Contributor

@JRAlexander JRAlexander commented Mar 19, 2019

Added the companion sample for the TensorFlow Image classification (transfer learning) tutorial.

Tutorial

@JRAlexander JRAlexander added the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Mar 19, 2019
@JRAlexander JRAlexander self-assigned this Mar 19, 2019
@JRAlexander JRAlexander changed the title [WIP] Add TransferLearningTF sample Add TransferLearningTF sample Mar 21, 2019
Copy link
Contributor

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @JRAlexander . Minor changes / suggestions.

Copy link
Contributor

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @JRAlexander . Minor snippet naming suggestion. I'll leave it up to you to decide if you want to change or not.


// Read the tags.tsv file and add the filepath to the image file name
// before loading into ImageData
// <SnippetReadFromCSV>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since method name changed from ReadFromCsv to ReadFromTsv, change snippet name to SnippetReadFromTSV to avoid confusion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, good catch. Already updated in tutorial

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@JRAlexander JRAlexander merged commit 17eb7a7 into dotnet:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants