Added VB example for NegotiateStream #737
Conversation
Added VB example for NegotiateStream
Added references to the VB samples. This commit is related to PR: dotnet/samples#737
rpetrusha
left a comment
rpetrusha
left a comment
There was a problem hiding this comment.
Thank you, @obelink, for adding another Visual Basic example. I've left a couple of comments that recommend some changes. Some of the blank lines could also be removed.
Are you also planning to submit a PR to add these examples to the NegotiateStream reference documentation?
| Imports System.Net.Sockets | ||
| Imports System.Net.Security | ||
| Imports System.Net | ||
| '<snippet0> |
There was a problem hiding this comment.
this line should be moved to precede Imports System.Text -- we want the list of imports to be included in the example.
| ' Pass the NegotiateStream as the AsyncState object | ||
| ' so that it is available to the callback delegate. | ||
| Dim ar = authStream.BeginAuthenticateAsClient( | ||
| New AsyncCallback(AddressOf EndAuthenticateCallback), authStream) |
| ' Encode the test data into a byte array. | ||
| Dim message = Encoding.UTF8.GetBytes("Hello from the client.") | ||
| ar = authStream.BeginWrite(message, 0, message.Length, | ||
| New AsyncCallback(AddressOf EndWriteCallback), authStream) |
|
Will take care of these changes. And yes, I will do a PR to add these samples to the documentation. Already started that, but saw thate there are much more VB samples involved for related/underlying pages. Wjat do you prefer.. Page by page or Topic by Topic? |
|
Topic by topic probably works best, @obelink. |
rpetrusha
left a comment
rpetrusha
left a comment
There was a problem hiding this comment.
Inadvertently approved this PR. Requesting changes again.
|
I've addressed my earlier comments, @obelink, so I'll merge your PR, as well as open a PR in dotnet/dotnet-api-docs to add the example to the documentation. We'd welcome additional VB examples as you have time. |
2 participants
This PR contributes to:
dotnet/dotnet-api-docs#2069
Added the VB example for NegotiateStream.