Clarify sort example per issue dotnet/dotnet-api-docs#1875 #801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added an additional "Jody" per issue dotnet/dotnet-api-docs#1875 to demonstrate how the sorting function handles duplicate values, and updated the sample unsorted and sorted output to demonstrate how the duplication is handled.
TashasEv
added a commit
to TashasEv/samples
that referenced
this pull request
Apr 9, 2019
For the .vb file (.cs file handled in dotnet#801) - I added an additional "Jody" to demonstrate how the sorting function handles duplicate values, and updated the sample unsorted and sorted output to demonstrate how the duplication is handled. Fixes dotnet/dotnet-api-docs#1875
Merged
BillWagner
approved these changes
Apr 9, 2019
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
Thanks for making this update @TashasEv
I've reviewed this, and I'll 
now.
Thanks for making the corresponding VB fix as well. @rpetrusha will review and merge that one.
Thanks for making your first contribution to docs! 🎆
BillWagner
pushed a commit
that referenced
this pull request
Apr 10, 2019
For the .vb file (.cs file handled in #801) - I added an additional "Jody" to demonstrate how the sorting function handles duplicate values, and updated the sample unsorted and sorted output to demonstrate how the duplication is handled. Fixes dotnet/dotnet-api-docs#1875
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I added an additional "Jody" to demonstrate how the sorting function handles duplicate values, and updated the sample unsorted and sorted output to demonstrate how the duplication is handled.
Fixes dotnet/dotnet-api-docs#1875