fix: Unscore XML and missed csharp "astoria" files #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@rpetrusha I think this should be the rest. There are some in the "cpp" folder, but I think that would be something to change with the cpp-docs repo separately |
Contributor
|
Not sure if the cpp docs are using the samples from here. The .NET content does have C++ examples too. |
Contributor
Author
|
I didn't see any of the cpp versions in the build warnings. It's possible they're orphans if the cpp-docs isn't using them. I didn't go looking in those docs for references though |
Contributor
|
Ok. Let's merge this and see if we get any warnings. It'd be good to clean up this repo as well at some point and remove unused samples. Oh well... |
mairaw
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.