Remove "recursive" from comment #837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #11744 The algorithm isn't really "recursive" because the `GetDirectories` will return all sub-directories, at any level from teh current directory. Therefore, the later calls to `Search` all search only for files. Update the comment to better reflect that.
rpetrusha
approved these changes
Apr 25, 2019
rpetrusha
left a comment
rpetrusha
left a comment
There was a problem hiding this comment.
I've left a comment for you to consider. You can merge when you're ready, @BillWagner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11744
The algorithm isn't really "recursive" because the
GetDirectorieswill return all sub-directories, at any level from teh current directory. Therefore, the later calls toSearchall search only for files.Update the comment to better reflect that.