Skip to content

fix min DWORD value #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2019
Merged

fix min DWORD value #843

merged 2 commits into from
Apr 24, 2019

Conversation

@mairaw
Copy link
Contributor

@mairaw mairaw commented Apr 23, 2019 •
edited
Loading

@mairaw mairaw requested a review from rpetrusha April 23, 2019 22:09
@mairaw mairaw requested a review from BillWagner as a code owner April 23, 2019 22:09
BillWagner
BillWagner approved these changes Apr 24, 2019
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @mairaw
You can :shipit: when ready.

@mairaw mairaw merged commit b136710 into master Apr 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the min-version branch April 24, 2019 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner BillWagner approved these changes

@rpetrusha rpetrusha Awaiting requested review from rpetrusha

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug in sample code for detecting .NET 4.8

3 participants

@mairaw @BillWagner