Clarify DateTime implicit conversion example #850
Conversation
It took some time for me to understand why the last example has -08:00 as offset. Since the example seemed to be about the addition of a TimeSpan the change in offset was quite confusing. Therefore, I split the example into two parts, one only focusing on the addition of a TimeSpan and the second on the adaption of the daylight time specific time zone. I also fixed a typo in the year given in line 84.
BillWagner
added
the
✨ 1st-time samples contributor!
|
Thanks for making this update @Crown0815 The C# changes look great. Can you make the corresponding update to the VisualBasic sample? The source is here: https://github.com/dotnet/samples/blob/master/snippets/visualbasic/VS_Snippets_CLR_System/system.DateTimeOffset.Operators/vb/Operators.vb#L113 After that, we'll merge this change. /cc @rpetrusha |
Adaption of changes made to the C# example in commit e1833f1 to the Visual Basic sample base. This change was made based on the feedback received to [PR dotnet#850](dotnet#850 (comment))
|
|
|
Thank you very much for your feedback @BillWagner. I adopted my changes to the C# sample to the VisualBasic sample as well. Please let me know if any further adoptions are necessary. I am very grateful for the opportunity to contribute. |
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
Thanks @Crown0815
I've reviewed both sets of changes, and this is ready to 
I've changed the base branch to "staging", and I'll merge this now. It will go live next week, during Build.
* Clarify DateTime implicit conversion example It took some time for me to understand why the last example has -08:00 as offset. Since the example seemed to be about the addition of a TimeSpan the change in offset was quite confusing. Therefore, I split the example into two parts, one only focusing on the addition of a TimeSpan and the second on the adaption of the daylight time specific time zone. I also fixed a typo in the year given in line 84. * Clarify DateTime implicit conversion VB example Adaption of changes made to the C# example in commit e1833f1 to the Visual Basic sample base. This change was made based on the feedback received to [PR #850](#850 (comment))
3 participants
Summary
It took some time for me to understand why the last example has -08:00 as offset. Since the example seemed to be about the addition of a TimeSpan the change in offset was quite confusing.
Therefore, I split the example into two parts, one only focusing on the addition of a TimeSpan and the second on the adaption of the daylight time specific time zone.
I also fixed a typo in the year given in line 84.
Fixes dotnet/dotnet-api-docs#2355