Skip to content

Conversation

@lindexi
Copy link
Member

@lindexi lindexi commented Apr 27, 2019

In corefx/coding-style.md at master · dotnet/corefx NO.1, we use Allman style braces, where each brace begins on a new line. A single line statement block can go without braces but the block must be properly indented on its own line and must not be nested in other statement blocks that use braces (See issue 381 for examples). One exception is that a using statement is permitted to be nested within another using statement by starting on the following line at the same indentation level, even if the nested using contains a controlled block.

NO.11, we use language keywords instead of BCL types.

lindexi and others added 7 commits March 23, 2019 08:30
In [corefx/coding-style.md at master · dotnet/corefx](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md ) NO.1, we use Allman style braces, where each brace begins on a new line. A single line statement block can go without braces but the block must be properly indented on its own line and must not be nested in other statement blocks that use braces (See issue 381 for examples). One exception is that a using statement is permitted to be nested within another using statement by starting on the following line at the same indentation level, even if the nested using contains a controlled block.
In [corefx/coding-style.md at master · dotnet/corefx](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md ) NO.11, we use language keywords instead of BCL types.
@lindexi lindexi requested a review from BillWagner as a code owner April 27, 2019 01:23
@lindexi
Copy link
Member Author

lindexi commented Apr 27, 2019

@rpetrusha rpetrusha changed the base branch from master to staging April 29, 2019 19:52
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changing the code to conform to standard coding conventions, @lindexi. We'll merge your PR now.

@rpetrusha rpetrusha merged commit b4be2c3 into dotnet:staging Apr 29, 2019
@lindexi lindexi deleted the t/lindexi/span branch April 30, 2019 00:32
Thraka pushed a commit that referenced this pull request May 1, 2019
* Fix code format

In [corefx/coding-style.md at master · dotnet/corefx](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md ) NO.1, we use Allman style braces, where each brace begins on a new line. A single line statement block can go without braces but the block must be properly indented on its own line and must not be nested in other statement blocks that use braces (See issue 381 for examples). One exception is that a using statement is permitted to be nested within another using statement by starting on the following line at the same indentation level, even if the nested using contains a controlled block.

* Fix code format

In [corefx/coding-style.md at master · dotnet/corefx](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md ) NO.11, we use language keywords instead of BCL types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants