Skip to content

Commit

Permalink
Remove the non-windows package verification message. (#43251)
Browse files Browse the repository at this point in the history
  • Loading branch information
marcpopMSFT committed Sep 9, 2024
2 parents 8f80ed2 + 97d4cb7 commit 047a2f1
Show file tree
Hide file tree
Showing 15 changed files with 0 additions and 92 deletions.
3 changes: 0 additions & 3 deletions src/Cli/dotnet/NugetPackageDownloader/LocalizableStrings.resx
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,6 @@
<data name="NuGetPackageShouldNotBeSigned" xml:space="preserve">
<value>Skipping signature verification for NuGet package "{0}" because it comes from a source that does not require signature validation.</value>
</data>
<data name="SkipNuGetpackageSigningValidationmacOSLinux" xml:space="preserve">
<value>Skip NuGet package signing validation. NuGet signing validation is not available on Linux or macOS https://aka.ms/workloadskippackagevalidation .</value>
</data>
<data name="FailedToValidatePackageSigning" xml:space="preserve">
<value>Failed to validate package signing.
{0}</value>
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -269,30 +269,6 @@ await nuGetPackageDownloader.DownloadPackageAsync(
File.Exists(packagePath).Should().BeTrue();
}

[UnixOnlyFact]
public async Task GivenANonWindowsMachineItShouldPrintMessageOnce()
{
BufferedReporter bufferedReporter = new();
NuGetPackageDownloader nuGetPackageDownloader = new(_tempDirectory, null,
new MockFirstPartyNuGetPackageSigningVerifier(),
_logger, bufferedReporter, restoreActionConfig: new RestoreActionConfig(NoCache: true));
await nuGetPackageDownloader.DownloadPackageAsync(
TestPackageId,
new NuGetVersion(TestPackageVersion),
new PackageSourceLocation(sourceFeedOverrides: new[] { GetTestLocalFeedPath() }));

// download 2 packages should only print the message once
string packagePath = await nuGetPackageDownloader.DownloadPackageAsync(
TestPackageId,
new NuGetVersion(TestPackageVersion),
new PackageSourceLocation(sourceFeedOverrides: new[] { GetTestLocalFeedPath() }));

bufferedReporter.Lines.Should()
.ContainSingle(
Cli.NuGetPackageDownloader.LocalizableStrings.SkipNuGetpackageSigningValidationmacOSLinux);
File.Exists(packagePath).Should().BeTrue();
}

[WindowsOnlyFact]
// https://aka.ms/netsdkinternal-certificate-rotate
public void ItShouldHaveUpdateToDateCertificateSha()
Expand Down

0 comments on commit 047a2f1

Please sign in to comment.