Skip to content

Commit

Permalink
Reenable test in GivenThatWeWantToRunILLink.cs (#42580)
Browse files Browse the repository at this point in the history
We just needed to update the expected method name.

Fixes dotnet/runtime#105857
  • Loading branch information
akoeplinger authored Aug 8, 2024
1 parent 7db47f7 commit 4cafca4
Showing 1 changed file with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -826,7 +826,6 @@ public void ILLink_verify_analysis_warnings_hello_world_app_trim_mode_copyused(s
ValidateWarningsOnHelloWorldApp(publishCommand, result, expectedWarnings, targetFramework, rid);
}

#if false // https://github.com/dotnet/runtime/issues/105857
[RequiresMSBuildVersionTheory("17.0.0.32901")]
[MemberData(nameof(Net6Plus), MemberType = typeof(PublishTestUtils))]
public void ILLink_verify_analysis_warnings_framework_assemblies(string targetFramework)
Expand Down Expand Up @@ -894,7 +893,7 @@ public void ILLink_verify_analysis_warnings_framework_assemblies(string targetFr
"ILLink : Trim analysis warning IL2026: System.ComponentModel.TypeDescriptor.NodeFor(Object, Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible.",
"ILLink : Trim analysis warning IL2026: System.ComponentModel.TypeDescriptor.NodeFor(Object, Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible.",
"ILLink : Trim analysis warning IL2026: System.ComponentModel.AmbientValueAttribute.AmbientValueAttribute(Type, String): Using member 'System.ComponentModel.AmbientValueAttribute.<.ctor>g__TypeDescriptorGetConverter|1_0(Type)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. AmbientValueAttribute usage of TypeConverter is not compatible with trimming.",
"ILLink : Trim analysis warning IL2026: System.ComponentModel.DefaultValueAttribute.DefaultValueAttribute(Type, String): Using member 'System.ComponentModel.DefaultValueAttribute.<.ctor>g__TryConvertFromInvariantString|4_0(Type, String, Object&)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. DefaultValueAttribute usage of TypeConverter is not compatible with trimming."
"ILLink : Trim analysis warning IL2026: System.ComponentModel.DefaultValueAttribute.DefaultValueAttribute(Type, String): Using member 'System.ComponentModel.DefaultValueAttribute.<.ctor>g__TryConvertFromInvariantString|5_0(Type, String, Object&)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. DefaultValueAttribute usage of TypeConverter is not compatible with trimming."
});
}

Expand All @@ -909,7 +908,6 @@ public void ILLink_verify_analysis_warnings_framework_assemblies(string targetFr
result.Should().Pass();
ValidateWarningsOnHelloWorldApp(publishCommand, result, expectedWarnings, targetFramework, rid);
}
#endif

[RequiresMSBuildVersionTheory("17.0.0.32901")]
[MemberData(nameof(Net6Plus), MemberType = typeof(PublishTestUtils))]
Expand Down

0 comments on commit 4cafca4

Please sign in to comment.