Skip to content

Commit

Permalink
add Digest null value to test scenario that was missed
Browse files Browse the repository at this point in the history
  • Loading branch information
baronfel authored and BeyondEvil committed Dec 20, 2024
1 parent 0324adb commit cbb0830
Showing 1 changed file with 1 addition and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ public async Task TarballsHaveCorrectStructure()
BuiltImage builtImage = imageBuilder.Build();

// Write the image to disk
var sourceReference = new SourceImageReference(registry, DockerRegistryManager.RuntimeBaseImage, DockerRegistryManager.Net7ImageTag);
var sourceReference = new SourceImageReference(registry, DockerRegistryManager.RuntimeBaseImage, DockerRegistryManager.Net7ImageTag, null);
var destinationReference = new DestinationImageReference(new ArchiveFileRegistry(archiveFile), NewImageName(), tags);

return (builtImage, sourceReference, destinationReference);
Expand Down Expand Up @@ -1214,11 +1214,7 @@ public async Task CanPackageForAllSupportedContainerRIDs(string dockerPlatform,
BuiltImage builtImage = imageBuilder.Build();

// Load the image into the local registry
<<<<<<< HEAD
var sourceReference = new SourceImageReference(registry, DockerRegistryManager.RuntimeBaseImage, DockerRegistryManager.Net9ImageTag);

Check failure on line 1217 in test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build TestBuild: macOS (x64))

test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs#L1217

test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs(1217,35): error CS7036: (NETCORE_ENGINEERING_TELEMETRY=Build) There is no argument given that corresponds to the required parameter 'Digest' of 'SourceImageReference.SourceImageReference(Registry?, string, string?, string?)'

Check failure on line 1217 in test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build TestBuild: macOS (arm64))

test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs#L1217

test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs(1217,35): error CS7036: (NETCORE_ENGINEERING_TELEMETRY=Build) There is no argument given that corresponds to the required parameter 'Digest' of 'SourceImageReference.SourceImageReference(Registry?, string, string?, string?)'

Check failure on line 1217 in test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build TestBuild: linux (x64))

test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs#L1217

test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs(1217,35): error CS7036: (NETCORE_ENGINEERING_TELEMETRY=Build) There is no argument given that corresponds to the required parameter 'Digest' of 'SourceImageReference.SourceImageReference(Registry?, string, string?, string?)'

Check failure on line 1217 in test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build TemplateEngine: macOS (x64))

test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs#L1217

test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs(1217,35): error CS7036: (NETCORE_ENGINEERING_TELEMETRY=Build) There is no argument given that corresponds to the required parameter 'Digest' of 'SourceImageReference.SourceImageReference(Registry?, string, string?, string?)'

Check failure on line 1217 in test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build TemplateEngine: linux (x64))

test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs#L1217

test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs(1217,35): error CS7036: (NETCORE_ENGINEERING_TELEMETRY=Build) There is no argument given that corresponds to the required parameter 'Digest' of 'SourceImageReference.SourceImageReference(Registry?, string, string?, string?)'

Check failure on line 1217 in test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build TestBuild: linux (arm64))

test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs#L1217

test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs(1217,35): error CS7036: (NETCORE_ENGINEERING_TELEMETRY=Build) There is no argument given that corresponds to the required parameter 'Digest' of 'SourceImageReference.SourceImageReference(Registry?, string, string?, string?)'

Check failure on line 1217 in test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build AoT: macOS (x64))

test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs#L1217

test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs(1217,35): error CS7036: (NETCORE_ENGINEERING_TELEMETRY=Build) There is no argument given that corresponds to the required parameter 'Digest' of 'SourceImageReference.SourceImageReference(Registry?, string, string?, string?)'

Check failure on line 1217 in test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build ContainerBased: linux (x64) [centosStream9])

test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs#L1217

test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs(1217,35): error CS7036: (NETCORE_ENGINEERING_TELEMETRY=Build) There is no argument given that corresponds to the required parameter 'Digest' of 'SourceImageReference.SourceImageReference(Registry?, string, string?, string?)'

Check failure on line 1217 in test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build ContainerBased: linux (x64) [ubuntu2204DebPkg])

test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs#L1217

test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs(1217,35): error CS7036: (NETCORE_ENGINEERING_TELEMETRY=Build) There is no argument given that corresponds to the required parameter 'Digest' of 'SourceImageReference.SourceImageReference(Registry?, string, string?, string?)'

Check failure on line 1217 in test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build ContainerBased: linux (x64) [alpine319WithNode])

test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs#L1217

test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs(1217,35): error CS7036: (NETCORE_ENGINEERING_TELEMETRY=Build) There is no argument given that corresponds to the required parameter 'Digest' of 'SourceImageReference.SourceImageReference(Registry?, string, string?, string?)'

Check failure on line 1217 in test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build ContainerBased: linux (x64) [fedora39])

test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs#L1217

test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs(1217,35): error CS7036: (NETCORE_ENGINEERING_TELEMETRY=Build) There is no argument given that corresponds to the required parameter 'Digest' of 'SourceImageReference.SourceImageReference(Registry?, string, string?, string?)'

Check failure on line 1217 in test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build ContainerBased: linux (x64) [debian12Amd64])

test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs#L1217

test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs(1217,35): error CS7036: (NETCORE_ENGINEERING_TELEMETRY=Build) There is no argument given that corresponds to the required parameter 'Digest' of 'SourceImageReference.SourceImageReference(Registry?, string, string?, string?)'
=======
var sourceReference = new SourceImageReference(registry, DockerRegistryManager.RuntimeBaseImage, DockerRegistryManager.Net9PreviewImageTag, null);
>>>>>>> 809df5c609 (Add support for using Digest for base image)
var destinationReference = new DestinationImageReference(registry, NewImageName(), new[] { rid });
await new DockerCli(_loggerFactory).LoadAsync(builtImage, sourceReference, destinationReference, default).ConfigureAwait(false);

Expand Down

0 comments on commit cbb0830

Please sign in to comment.