New winmd reference enforcement targets wrong items

[Scottj1s]

The csc task uses ReferencePathWithRefAssemblies, rather than ReferencePath:

C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\Roslyn\Microsoft.CSharp.Core.targets(111):
References="@(ReferencePathWithRefAssemblies)"

/cc @jkoritzinsky

[jaredpar]

That behavior is expected from our perspective. Can you elaborate on why you think this is a bug?

[Scottj1s]

@jaredpar It presents a false negative. I can try to address a NETSDK11130 by removing ReferencePath items, and _BlockWinMDsOnUnsupportedTFMs will no longer trigger an error. But csc will still receive the winmd references, creating a potentially incorrect assembly.

[jaredpar]

Still not sure how this is a bug in the csc task though. Our MSBuild API is to use this item group as our input for references. This is a design done in collaboration with MSBuild to ensure we get the proper benefits from reference assemblies at build times. Moving to @(ReferencePath) would explicitly go against that design.

It sounds like another target updating the incorrect item group here and that is the source of the issue. Can't tell from the discussion though where this would be occuring.

[Scottj1s]

There's nothing wrong with the csc task, but with the _BlockWinMDsOnUnsupportedTFMs target

[Scottj1s]

that may not have been clear in my description. The _BlockWinMDsOnUnsupportedTFMs is targeting the wrong item (ReferencePath) because the csc task refers to ReferencePathWithRefAssemblies

[jaredpar]

@Scottj1s gotcha. Thanks for the clarification. Moving to SDK as this is one of their targets.