Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API Compat] Add rule that prohibits sealing an inheritable type #18685

Closed
safern opened this issue Jul 1, 2021 · 1 comment · Fixed by #19063
Closed

[API Compat] Add rule that prohibits sealing an inheritable type #18685

safern opened this issue Jul 1, 2021 · 1 comment · Fixed by #19063
Labels
Area-ApiCompat
Milestone
6.0.1xx

Comments

@safern
Copy link
Member

safern commented Jul 1, 2021

This rule checks if the type is non inheritable on both the implementation and contract:

  1. Has the sealed modifier
  2. Has no non static visible constructors outside the assembly.

cc: @ericstj @Anipik
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label Jul 1, 2021
@safern safern added Area-ApiCompat and removed untriaged Request triage from a team member labels Jul 1, 2021
@safern safern added this to the 6.0.1xx milestone Jul 1, 2021
@safern safern mentioned this issue Jul 1, 2021
Closed
18 tasks
@safern safern mentioned this issue Jul 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-ApiCompat
Projects
None yet
Milestone
6.0.1xx
Development

Successfully merging a pull request may close this issue.

[API Compat] Add rule that validates an inheritable type is not sealed safern/sdk
1 participant
@safern