Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API Compat] Add rule that validates an inheritable type is not sealed #19063

Merged
merged 3 commits into from
Jul 20, 2021
Merged

[API Compat] Add rule that validates an inheritable type is not sealed #19063

merged 3 commits into from
Jul 20, 2021

Conversation

safern
Copy link
Member

@safern safern commented Jul 20, 2021

Fixes: #18685

@safern safern requested review from ericstj and Anipik July 20, 2021 06:17
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@safern safern added this to the 6.0.1xx milestone Jul 20, 2021
@safern
Copy link
Member Author

safern commented Jul 20, 2021

I addressed all feedback and fixed the issue with the removal of a public constructor not being reported.

ericstj
ericstj approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo one nit.

src/Tests/Microsoft.DotNet.ApiCompatibility.Tests/Rules/MembersMustExistTests.cs Outdated Show resolved Hide resolved
@safern safern enabled auto-merge (squash) July 20, 2021 22:51
@safern safern merged commit f6f914a into dotnet:main Jul 20, 2021
v-wuzhai pushed a commit that referenced this pull request Apr 22, 2024
@premun
Add a PR version of VMR pipelines (#19063)
137a9b6
ViktorHofer pushed a commit that referenced this pull request May 7, 2024
@premun
Add a PR version of VMR pipelines (#19063)
283cc09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anipik Anipik Anipik left review comments

@ericstj ericstj ericstj approved these changes

Assignees
No one assigned
Labels
Area-ApiCompat
Projects
None yet
Milestone
6.0.1xx
Development

Successfully merging this pull request may close these issues.

[API Compat] Add rule that prohibits sealing an inheritable type
3 participants
@safern @ericstj @Anipik