Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Represent FrameworkReference of transitive projects and packages in the deps.json file. #2729

Closed
NTaylorMullen opened this issue Dec 7, 2018 · 3 comments
Assignees
Milestone

Comments

@NTaylorMullen
Copy link
Contributor

NTaylorMullen commented Dec 7, 2018

Today transitive project/package references aren't properly represented in a deps.json. For instance given this project (Bug4332 is a web app, Bug4332RCL is a Razor class library, both targeting netcoreapp3.0):
image

Today you get the following Bug4332.deps.json entry for Bug4332RCL:

      "Bug4332RCL/1.0.0": {
        "runtime": {
          "Bug4332RCL.dll": {}
        },
        "compile": {
          "Bug4332RCL.dll": {}
        }
      },

The min-bar expectation would be for the deps.json to look something like:

      "Bug4332RCL/1.0.0": {
        "dependencies": {
          "Microsoft.AspNetCore.App": "3.0.0-preview-18579-0056"
        },
        "runtime": {
          "Bug4332RCL.dll": {}
        },
        "compile": {
          "Bug4332RCL.dll": {}
        }
      },

This is blocking a core scenario in ASP.NET Core MVC 3.0 of having Razor views in a class library.

Lastly, I imagine this issue depends on the completion of the following (please correct me if i'm wrong):

@livarcocc @dsplaisted @natemcmaster @mkArtakMSFT @rynowak

@NTaylorMullen NTaylorMullen changed the title Represent FrameworkReference of transitive project's and package's in the deps.json file. Represent FrameworkReference of transitive projects and packages in the deps.json file. Dec 7, 2018
@livarcocc livarcocc added this to the 3.0.1xx milestone Dec 10, 2018
@livarcocc
Copy link
Contributor

@dsplaisted @nguerrera want to make sure that framework composition accounts for this.

@nguerrera
Copy link
Contributor

Of course this has to be handled in the changes we have planned, but it's strange that it's already broken because today a FrameworkReference still becomes a standard package reference. It's unclear to me what is different enough from 2.x to cause this. We should make sure we understand that and not just tie this to composition.

@dsplaisted
Copy link
Member

ASP.NET switched to discovering which assemblies should be scanned at build time, and encoding that information in assembly attributes, and as such no longer need the FrameworkReferences to be encoded in the deps.json. So we are going to close this, and can revisit it if we encounter another scenario where this would be needed.

wli3 pushed a commit that referenced this issue Feb 7, 2020
….7 (#2729)

- Microsoft.DotNet.Cli.Runtime - 5.0.100-alpha1.19458.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants