Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building project with twice (or more) transitive dependencies explodes. #353

Closed
NTaylorMullen opened this issue Nov 3, 2016 · 4 comments

Comments

@NTaylorMullen
Copy link
Contributor

NTaylorMullen commented Nov 3, 2016

Repro

Given the following setup: Project1 => Project2 => Project3.

When you restore Project1 you get an entry for Project2 and Project3 in the assets.json file. However, when you build Project1 Project3 is never passed to csc.

Trying restoring/building the following: TransitiveCSCRepro.zip

dotnet info:

.NET Command Line Tools (1.0.0-preview3-004007)

Product Information:
 Version:            1.0.0-preview3-004007
 Commit SHA-1 hash:  80ec02b4da

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.14393
 OS Platform: Windows
 RID:         win10-x64

SDK: 1.0.0-alpha-20161029-1

@dsplaisted
Copy link
Member

I think I recall that this is the intended behavior. You will get transitive project references in the output folder, but only direct project references get passed to the compiler.

@srivatsn
Copy link
Contributor

srivatsn commented Nov 3, 2016

Isn't this just dotnet/project-system#199 - that we don't support transitive project references yet.

@NTaylorMullen
Copy link
Contributor Author

So NuGet handles this correctly (updates the assets.json). The bits that are left is letting MSBuild bits (this issue) and the UI work to show the inherited dependencies. Unless I'm missing something dotnet/project-system#199 would still require work in this repo to be done.

This issue ends up also being a dotnet pack problem as well.

@nguerrera
Copy link
Contributor

Closing as dup of #200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants