Skip to content

Transitive package framework assembly references don't get included in build. #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
NTaylorMullen opened this issue Nov 8, 2016 · 0 comments
Closed

Transitive package framework assembly references don't get included in build. #365

NTaylorMullen opened this issue Nov 8, 2016 · 0 comments
Assignees
@natidea
Labels
Bug
Milestone
1.0 RC3

Comments

@NTaylorMullen
Copy link

NTaylorMullen commented Nov 8, 2016 •
edited
Loading

Trying to utilize a transitive package framework assembly reference results in build errors. From the looks of it, the transitive framework assembly references are not passed over to csc but are included in the restore file.

Note: This used to work in project.json land.

See the simple repro here:
FrameworkAssemblyRepro.zip

/cc @barrytang @Eilon
@srivatsn srivatsn added the Bug label Nov 8, 2016
@srivatsn srivatsn added this to the 1.0 RC2 milestone Nov 8, 2016
@NTaylorMullen NTaylorMullen mentioned this issue Nov 8, 2016
Closed
55 tasks
@srivatsn srivatsn assigned natidea and unassigned nguerrera Nov 21, 2016
@srivatsn srivatsn modified the milestones: 1.0 RC3, 1.0 RC2 Nov 29, 2016
natidea added a commit to natidea/sdk that referenced this issue Dec 13, 2016
@natidea
Add Framework Assemblies raised from project assets file to compiler …
35049cf 
…references.

Fixes dotnet#365 and dotnet#409. Note that implicit framework references already address the scenario in dotnet#409 which only relies on 'System'
@natidea natidea mentioned this issue Dec 13, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@natidea natidea

Labels
Bug
Projects
None yet
Milestone
1.0 RC3
Development

No branches or pull requests
4 participants
@srivatsn @nguerrera @NTaylorMullen @natidea