Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnet pack doesn't generate XML docs #4682

Closed
victorhurdugaci opened this issue Dec 21, 2015 · 5 comments
Closed

dotnet pack doesn't generate XML docs #4682

victorhurdugaci opened this issue Dec 21, 2015 · 5 comments
Assignees
@analogrelay
Labels
Bug
Milestone
1.0.0-rc2

Comments

@victorhurdugaci
Copy link

dnu pack used to generate xml docs. It seems that dotnet pack doesn't do the same.

Unless I'm missing something, there doesn't seem to be any way to get xml docs generated with dotnet.

cc @anurse @davidfowl
@davidfowl
Copy link
Member

Good catch! We should probably implement #4459 as part of this.

/cc @pakrym @agocke @jaredpar

@analogrelay analogrelay self-assigned this Jan 8, 2016
@analogrelay
Copy link
Contributor

This was actually already working, dotnet-compile just wasn't generating the XML file. Once #4459 was fixed this came for free.

@victorhurdugaci
Copy link
Author

@ajaybhargavb can you please check, once the build completes, that this one fixes the nuget verifier? It should pass now

@ajaybhargavb
Copy link
Contributor

I just tried building Common repo. It still doesn't generate the XML files. @anurse could you please check if the latest build has the fix?

@analogrelay
Copy link
Contributor

Figured this out in person, we need to set compilationOptions.xmlDoc to true in the project.json. As in https://github.com/dotnet/cli/blob/master/test/TestProjects/TestLibrary/project.json

@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
@msftgits msftgits added this to the 1.0.0-rc2 milestone Jan 31, 2020
rainersigwald pushed a commit to rainersigwald/sdk that referenced this issue Jul 20, 2020
@dotnet-maestro
Update dependencies from https://github.com/dotnet/cli build 20200713…
1963117 
….1 (dotnet#4682)

Microsoft.DotNet.Cli.Runtime
 From Version 3.1.400-preview.20360.1 -> To Version 3.1.400-preview.20363.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@analogrelay analogrelay

Labels
Bug
Projects
None yet
Milestone
1.0.0-rc2
Development

No branches or pull requests
5 participants
@analogrelay @davidfowl @ajaybhargavb @victorhurdugaci @msftgits