ResolvePackageDependencies produces incorrect Resolved paths for project references

[natidea]

ResolvePackageDependencies resolves paths for project references were computed based on the project root, which was originally based on the location of the project lock file. This needs to be updated or removed since the assets file has moved, and the assets file may contain more appropriate root folder information.

The resolved path for project references is not actually used anywhere currently, so this bug does not cause any problems, but should be fixed anyway.

[BrunoJuchli]

Also see #1435 (duplicate) for an example of invalid data.

@natidea could you please update the issue description to include what the actual content of ResolvedPath should be? (Unless it's being fixed by #1442 already.) Should it point to the csproj or should it point to where the build-output (dlls...) of the referenced project are located?

[BrunoJuchli]

Usages of ResolvedPath (not including tests):

• Target _ComputeLockFilesReferences
• Target _HandlePackageFileConflicts
  -- Only where Type == assembly
• Target ComputeRefAssembliesToPublish
• Task ProduceContentAssets
• Task PreprocessPackageDependenciesDesignTime

On first glance I couldn't see any file-path sanity checks so I guesstimate it's true that ResolvedPath of <ProjectReference />s are not being used - otherwise the issue should have made itself known beforehand. Ok with the places where the ResolvedPath is used for exclusion this is not actually true - these might not have been spotted. But as far as I can see these only pertain to framework assemblies, right?

[nguerrera]

Fixed by #1442