ResolvePackageDependencies produces invalid ResolvedPath for <ProjectReference .../>

[BrunoJuchli]

Running on latest previews (VS2017.3 Preview 4, .net sdk 2.0.0-preview2-006497) my build fails because the ResolvePackageDependencies Task produces invalid results / output. I'm building from within VS.

In short, a path included in @(PackageDefinitions->'%(ResolvedPath)' is wrong. Here is the actual vs the expected path:

C:\Development\StaticProxy.Fody.VS2017\IntegrationTests\StaticProxy.Fody\StaticProxy.Fody.csproj
C:\Development\StaticProxy.Fody.VS2017\StaticProxy.Fody\StaticProxy.Fody.csproj

The actual path does not exist, that's why a consumer of this path fails.

The complete output for that particular PackageDefinition (which results from a <ProjectReference Include="..\StaticProxy.Fody\StaticProxy.Fody.csproj" />) is:

2> StaticProxy.Fody/1.0.0
2> Name=StaticProxy.Fody
2> Path=../StaticProxy.Fody/StaticProxy.Fody.csproj
2> ResolvedPath=C:\Development\StaticProxy.Fody.VS2017\IntegrationTests\StaticProxy.Fody\StaticProxy.Fody.csproj
2> Type=project
2> Version=1.0.0

Excerpts from the *.csproj of the project (targeting net462) follows, but I would like to mention that some of the projects in the solution actualy do target netstandard - don't know if that makes a difference?

<?xml version="1.0" encoding="utf-8"?>
<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
	<TargetFrameworks>net462</TargetFrameworks>
  </PropertyGroup>
  <ItemGroup>
	<Reference Include="System" />
	...
	<PackageReference Include="Castle.Core" Version="4.1.1" />
	...
  </ItemGroup>
  ...
  <ItemGroup>
	<ProjectReference Include="..\StaticProxy.Fody\StaticProxy.Fody.csproj" />
  </ItemGroup>
</Project>

Link to project: https://github.com/BrunoJuchli/StaticProxy.Fody/tree/7d8b924d90759cb3248803514ba631463358494a/

Diagnostic MSBuild Log: https://gist.github.com/BrunoJuchli/c5c8b5e74571cbaa99e8e8e5997acaf3/raw/9bc0f0bd94cd77ccf0cbfb58bf66982dfca961bb/MsBuildLog.txt

[BrunoJuchli]

The task receives:

ProjectAssetsFile=C:\Development\StaticProxy.Fody.VS2017\IntegrationTests\obj\project.assets.json
ProjectPath=C:\Development\StaticProxy.Fody.VS2017\IntegrationTests\IntegrationTests.csproj

GetAbsolutePathFromProjectRelativePath(package.MSBuildProject) is called and performs this:

return Path.GetFullPath(
               Path.Combine(
                   Path.GetDirectoryName(
                          Path.GetFullPath(ProjectAssetsFile))
                   , path));

The result of this call is then set as the ResolvedPath metadata.

Based on my observed result (C:\Development\StaticProxy.Fody.VS2017\IntegrationTests\StaticProxy.Fody\StaticProxy.Fody.csproj) I deduct that path must be (the same as specified in the csproj): ..\StaticProxy.Fody\StaticProxy.Fody.csproj.

The path in the csproj is relative to the location of the csproj.
Is there any reason there should be some Voodoo-magic involved rebasing all paths to the location of the ProjectAssetsFile? It seems (unnecessarily) complicated.
So my guess is that that's where the bug lies.

Which means the implementation should be changed to:

return Path.GetFullPath(
               Path.Combine(
                   Path.GetDirectoryName(ProjectPath)
                   , path));

I removed the second Path.GetFullPath call as - at least in my scenario - the Task already received the ProjectPath as FullPath. Is this always the case?

[BrunoJuchli]

Duplicate of #479