-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Description
The runtime repo and aspnetcore repo both have a setting so 'build analysis' is green if all issues are known issues. The SDK repo gets a large amount of code flow so we would also greatly accelerate by enabling this feature. Add dotnet-aspnetcore to Merge On Green config table · Issue #5430 · dotnet/dnceng This was tracked here for aspnetcore and linked is a thread for reference... shout out to @ilonatommy for the suggestion.
Step 1 - Data Table Config
I don't have access to that, but @missymessa is helping configure it.
Here's what our config should be. Or at least what I think it should be.
Row key defines the branches the rule impacts. I want this to help with dnup too and all other branches so I dont see a need to condition it to release/*.
Partition Key: dotnet-sdk
Row Key: *
ShouldMergeOnFailureWithKnownIssues: True
Step 2 - Repo Config
I also dont have access to that.
@marcpopMSFT or @dsplaisted, may you please:
Go to:
https://github.com/dotnet/sdk/settings/branches
Then for our branches (preferably all of them, in my opinion), change the required checks to only 'Build Analysis'?
Concerns
@marcpopMSFT mentioned that there was a bug in the BA check that made it green when legs were initially created. This is a great concern. I imagine it would mostly impact automerge. I couldn't find the issue either, but I tried to see if it repro'd and could not repro it. I'd say we should be careful and see if that becomes an issue after this change.. and I'm currently on duty so I get to deal with it 😁 That's ok...