Explicit RID still required for .NET Framework test projects

[natemcmaster]

RID inference for .NET Framework is conditioned on 'OutputType=exe'. Test projects, however, may still be "executable" even if compile as a library.

This means test projects for .NET Framework with native assets will fail. Either need a RID or users need to set OutputType=exe, which is not the default template setting.

Repro

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFramework>net46</TargetFramework>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.Data.Sqlite" Version="1.1.0" />
    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.0.0" />
    <PackageReference Include="xunit" Version="2.2.0" />
    <PackageReference Include="xunit.runner.visualstudio" Version="2.2.0" />
  </ItemGroup>

</Project>

using Microsoft.Data.Sqlite;
using Xunit;

public class SqliteConnectionTest
{
    [Fact]
    public void OpensConnection()
    {
        new SqliteConnection("Data Source=:memory:").Open();
    }
}

dotnet restore
dotnet test

Expected
Infers RID to win7-x86/x64 and test work :)

Actual
Tests build, but fail because the native component "sqlite3.dll" is missing from build output.

[xUnit.net 00:00:00.8776695]     SqliteConnectionTest.OpensConnection [FAIL]
[xUnit.net 00:00:00.8784311]       System.DllNotFoundException : Unable to load DLL 'sqlite3': The specified module could not be found. (Exception from HRESULT: 0x8007007E)

Details
dotnet --version: 1.0.0-rc4-004883

Workarounds
Add a <RuntimeIdentifier> or set <OutputType>exe</OutputType>.

[eerhardt]

Adding Blocking Partner since I just "closed as duplicate" an issue that was Blocking Partner.

[livarcocc]

@nguerrera this is the issue we chatted about before. Take a look when you have time.

[nguerrera]

This will be fixed by #1178 once the test project sets HasRuntimeOutput to true, which is now tracked by microsoft/vstest#792

[natemcmaster]

This is not fixed by #1178. Even if you add HasRuntimeOutput to the test project, you still need the explicit RID.

Repro

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFramework>net46</TargetFramework>
    <HasRuntimeOutput>true</HasRuntimeOutput>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.Data.Sqlite" Version="1.1.0" />
    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.3.0-*" />
    <PackageReference Include="xunit" Version="2.2.0" />
    <PackageReference Include="xunit.runner.visualstudio" Version="2.2.0" />
  </ItemGroup>

</Project>

using Microsoft.Data.Sqlite;
using Xunit;

public class SqliteConnectionTest
{
    [Fact]
    public void OpensConnection()
    {
        new SqliteConnection("Data Source=:memory:").Open();
    }
}

dotnet SDK 2.0.0-preview2-006098

Result

System.DllNotFoundException : Unable to load DLL 'sqlite3':

Workdaround
add explicit rid

<RuntimeIdentifier>win7-x64</RuntimeIdentifier>

[natemcmaster]

@nguerrera is this just because latest CLI hasn't ingested the SDK?

[nguerrera]

I think so. I'll check.

[nguerrera]

Yes, that was it. dotnet/cli#6665 is out to update the SDK in the CLI.

[natemcmaster]

Thanks @nguerrera